From c8cddd01dfde45f08932e376cf221b7b1bb402ec Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 14:14:15 +0200 Subject: [PATCH 01/26] =?UTF-8?q?editing=20nimmt=20jtz=20eine=20Funktion?= =?UTF-8?q?=20onFailure=20die=20ausgef=C3=BChrt=20wird=20bei=20einem=20feh?= =?UTF-8?q?ler?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/shared/editing.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/main/resources/static/js/shared/editing.js b/src/main/resources/static/js/shared/editing.js index 2174204..7153a36 100644 --- a/src/main/resources/static/js/shared/editing.js +++ b/src/main/resources/static/js/shared/editing.js @@ -1,7 +1,7 @@ import { abortEditing, createEditForm } from "./sharedUI.js"; import { handleResponse } from "./helper.js"; -export async function editElement({ element, fields, apiCall, id, onSuccess, errmsg }) { +export async function editElement({ element, fields, apiCall, id, onSuccess, onFailure, errmsg }) { const formElement = createEditForm(fields); element.replaceWith(formElement); @@ -14,9 +14,14 @@ export async function editElement({ element, fields, apiCall, id, onSuccess, err let formData = Object.fromEntries(new FormData(formElement)); let result = await handleResponse(apiCall(id, formData), errmsg); - abortEditing(formElement, element); - if (result) onSuccess(formData); + if (result) { + onSuccess(formData); + abortEditing(formElement, element); + } else { + onFailure(result); + + } }); formElement.addEventListener("click", (e) => { From 1c796e4badf411184419b34a4cc1b8415cb8522b Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 14:14:24 +0200 Subject: [PATCH 02/26] eingabefelder werden rot markiert bei falscher iengabe --- .../resources/static/js/pages/list/list.js | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index 8c677f8..5499d65 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -99,6 +99,20 @@ function init() { { name: "itemAmount", value: itemAmount, class: "editForm__amount", attr: "item-amount" } ] , onSuccess: (f) => { sharedUI.setElementAttributes(shoppingItemElement, { "item-name": f.itemName, "item-amount": f.itemAmount }) } + , onFailure: (result) => { + let errorTimer; + document.querySelector("input.editForm__name").classList.add("is-invalid"); + document.querySelector("input.editForm__amount").classList.add("is-invalid"); + + clearTimeout(errorTimer); + errorTimer = (setTimeout(() => { + + document.querySelector(".editForm__name").classList.remove("is-invalid"); + document.querySelector("input.editForm__amount").classList.remove("is-invalid"); + + }, 5000)); + + } , errmsg: `konnte Item nicht bearbeiten` }); @@ -119,6 +133,16 @@ function init() { sharedUI.setElementAttributes(categoryElement, { "category-name": f.categoryName }) document.querySelector(`option[value='${id}']`).textContent = f.categoryName; } + , onFailure: (result) => { + let errorTimer; + document.querySelector("input.editForm__name").classList.add("is-invalid"); + clearTimeout(errorTimer); + errorTimer = (setTimeout(() => { + + document.querySelector(".editForm__name").classList.remove("is-invalid"); + }, 5000)); + + } , errmsg: `konnte Kategorie nicht bearbeiten` }); From 9f63b689fc3f171c95cb69161ad2996b799797fb Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:06:45 +0200 Subject: [PATCH 03/26] error.js erstellt jtz einen span mit de fehlernachricht --- src/main/resources/static/js/shared/error.js | 26 ++++---------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/src/main/resources/static/js/shared/error.js b/src/main/resources/static/js/shared/error.js index fb53e23..b3c2f5c 100644 --- a/src/main/resources/static/js/shared/error.js +++ b/src/main/resources/static/js/shared/error.js @@ -1,22 +1,6 @@ -const errorDiv = document.createElement("div"); -const errorSpan = document.createElement("span"); -let errorTimer; - -export function showError(msg) { - errorSpan.textContent = msg; - errorDiv.hidden = false - - clearTimeout(errorTimer); - errorTimer = (setTimeout(() => { - errorDiv.hidden = true; - errorSpan.textContent = ""; - }, 3000)); -} - - -export function initErrors(element) { - errorDiv.hidden = true; - errorDiv.append(errorSpan); - - element.append(errorDiv); +export function createErrorSpan(msg) { + const span = document.createElement("span"); + span.textContent = msg; + span.classList.add("error-message"); + return span; } From 719f6336151868fd638f794addd092c50f30b82d Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:06:56 +0200 Subject: [PATCH 04/26] =?UTF-8?q?handleResponse=20gibt=20ein=20objekt=20mi?= =?UTF-8?q?t=20ok=20und=20json=20zur=C3=BCck?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/shared/helper.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/resources/static/js/shared/helper.js b/src/main/resources/static/js/shared/helper.js index 26f4b29..4fcce7a 100644 --- a/src/main/resources/static/js/shared/helper.js +++ b/src/main/resources/static/js/shared/helper.js @@ -1,21 +1,19 @@ -import { showError } from "./error.js"; export async function handleResponse(promise, errorMsg) { const response = await promise; //weil 204 kein body ist un damit unparsbar, geben wir vorab true zurück if (response.status == 204) { - return true; + return { ok: true, json: null }; } const json = await response.json(); if (!response.ok) { - showError(json.msg); console.error(errorMsg); - return false; + return { ok: false, json: json }; } - return json; + return { ok: true, json: json }; } From 882c4d27071c1a7f072ea28a1ff1319011c5b2c8 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:14:46 +0200 Subject: [PATCH 05/26] an neues handleResponse return angepasst --- src/main/resources/static/js/pages/list/list.js | 12 +++++------- src/main/resources/static/js/shared/editing.js | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index 5499d65..950f18f 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -1,6 +1,5 @@ import { ShoppingCategory } from "../../models/ShoppingCategory.js"; import { ShoppingItem } from "../../models/ShoppingItem.js"; -import { initErrors } from "../../shared/error.js"; import * as api from "./api/listAPI.js" import * as ui from "./frontend/listUI.js" import { handleResponse } from "../../shared/helper.js"; @@ -16,14 +15,14 @@ async function addItem(itemName, itemAmount, categoryID) { console.log(` adding item with id:${currentList.dataset.id}, name: ${itemName}, amount: ${itemAmount}, category: ${categoryID}`) const json = await handleResponse(api.addItem(currentList.dataset.id, itemName, itemAmount, categoryID), `item couldnt be created!`); - if (json) ui.addItem(json); + if (json.ok) ui.addItem(json.json); } async function addCategory(categoryName) { console.log(`adding category ${categoryName}`) const json = await handleResponse(api.addCategory(currentList.dataset.id, categoryName), `category couldnt be added!`); - if (json) ui.addCategory(json); + if (json.ok) ui.addCategory(json.json); } @@ -31,25 +30,24 @@ async function deleteItem(li) { console.log(`deleting item ${li.dataset.id}`) const json = await handleResponse(api.deleteItem(li.dataset.id), `error deleting item`); - if (json) ui.deleteItem(li); + if (json.ok) ui.deleteItem(li); } async function deleteCategory(deleteAllItems, categoryID) { console.log(`deleting category with allItems: ${deleteAllItems} id: ${categoryID}`); const json = await handleResponse(api.deleteCategory(deleteAllItems, categoryID), `error deleting category`); - if (json) ui.deleteCategory(deleteAllItems, categoryID); + if (json.ok) ui.deleteCategory(deleteAllItems, categoryID); } async function deleteAllDoneItems() { console.log(`deleting all done items...`) const json = await handleResponse(api.deleteAllDoneItems(currentList.dataset.id), `error deleting all done items`); - if (json) ui.deleteAllDoneItems(); + if (json.ok) ui.deleteAllDoneItems(); } function init() { - initErrors(document.querySelector(".nav")); customElements.define("shopping-item", ShoppingItem); customElements.define("shopping-category", ShoppingCategory); diff --git a/src/main/resources/static/js/shared/editing.js b/src/main/resources/static/js/shared/editing.js index 7153a36..e632a56 100644 --- a/src/main/resources/static/js/shared/editing.js +++ b/src/main/resources/static/js/shared/editing.js @@ -15,7 +15,7 @@ export async function editElement({ element, fields, apiCall, id, onSuccess, onF let result = await handleResponse(apiCall(id, formData), errmsg); - if (result) { + if (result.ok) { onSuccess(formData); abortEditing(formElement, element); } else { From ea36b16a87af00f87bef797db7941dc098871412 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:15:03 +0200 Subject: [PATCH 06/26] =?UTF-8?q?category=20hat=20jtz=20einen=20innerHeade?= =?UTF-8?q?r=20div=20f=C3=BCr=20bessere=20anordnung?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/models/ShoppingCategory.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/main/resources/static/js/models/ShoppingCategory.js b/src/main/resources/static/js/models/ShoppingCategory.js index 57a3439..1a9ab8c 100644 --- a/src/main/resources/static/js/models/ShoppingCategory.js +++ b/src/main/resources/static/js/models/ShoppingCategory.js @@ -9,7 +9,9 @@ export class ShoppingCategory extends HTMLElement { connectedCallback() { if (this._rendered) return; + const categoryHeaderDiv = document.createElement("div"); + const categoryHeaderInnerDiv = document.createElement("div"); const span = document.createElement("span"); const deleteCategoryButton = document.createElement("button"); const deleteAllItemsLabel = document.createElement("label"); @@ -19,6 +21,7 @@ export class ShoppingCategory extends HTMLElement { categoryHeaderDiv.classList.add("category__header"); + categoryHeaderInnerDiv.classList.add("category__innerHeader"); span.textContent = this.getAttribute("category-name"); span.classList.add("category__name", "category__name--bold", "category__name--big"); @@ -33,7 +36,9 @@ export class ShoppingCategory extends HTMLElement { deleteAllItemsLabel.append(deleteAllItemsCheckbox); - categoryHeaderDiv.append(span, deleteCategoryButton, deleteAllItemsLabel); + categoryHeaderInnerDiv.append(span, deleteCategoryButton, deleteAllItemsLabel); + + categoryHeaderDiv.append(categoryHeaderInnerDiv); this.prepend(categoryHeaderDiv); From 569e5223f25c7ffc4933df7ab335876bd0e022fe Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:15:25 +0200 Subject: [PATCH 07/26] =?UTF-8?q?editForm=20hat=20jtz=20Klasse=20f=C3=BCr?= =?UTF-8?q?=20bessere=20Kontrolle?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/shared/sharedUI.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/resources/static/js/shared/sharedUI.js b/src/main/resources/static/js/shared/sharedUI.js index a4f7bde..14cc000 100644 --- a/src/main/resources/static/js/shared/sharedUI.js +++ b/src/main/resources/static/js/shared/sharedUI.js @@ -25,6 +25,7 @@ export function createEditForm(fields) { editForm.append(...inputs, saveButton, abortButton); + editForm.classList.add("editForm"); return editForm; } From 5b6a8e67bf8b2e1d738adf62dcb5e77f520dec43 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:22:55 +0200 Subject: [PATCH 08/26] editCategory angepasst, dass es den innerHeader entfernt und die fehlernachricht anzeigt, die felder rot markiert --- .../resources/static/js/pages/list/list.js | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index 950f18f..56dd48b 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -5,6 +5,7 @@ import * as ui from "./frontend/listUI.js" import { handleResponse } from "../../shared/helper.js"; import { editElement } from "../../shared/editing.js"; import * as sharedUI from "../../shared/sharedUI.js"; +import { createErrorSpan } from "../../shared/error.js"; const addCategoryForm = document.querySelector(".addCategoryForm"); const addItemForm = document.querySelector(".addItemForm"); @@ -117,13 +118,13 @@ function init() { } else if (event.target.closest(".category__name")) { const categoryElement = event.target.closest("shopping-category"); - const categoryHeader = event.target.closest(".category__header"); + const categoryInnerHeader = event.target.closest(".category__innerHeader"); const id = event.target.closest("li").dataset.id; let categoryName = categoryElement.querySelector(".category__name").textContent; editElement({ - element: categoryHeader, apiCall: api.editCategory, id: id, + element: categoryInnerHeader, apiCall: api.editCategory, id: id, fields: [ { name: "categoryName", value: categoryName, class: "editForm__name", attr: "category-name" }, ] @@ -131,15 +132,21 @@ function init() { sharedUI.setElementAttributes(categoryElement, { "category-name": f.categoryName }) document.querySelector(`option[value='${id}']`).textContent = f.categoryName; } - , onFailure: (result) => { + , onFailure: (response) => { let errorTimer; - document.querySelector("input.editForm__name").classList.add("is-invalid"); + const editForm = document.querySelector(".editForm"); + const editName = document.querySelector(".editForm__name"); + const err = createErrorSpan(response.json.msg); + + editName.classList.add("is-invalid"); + editForm.append(err); + clearTimeout(errorTimer); errorTimer = (setTimeout(() => { - document.querySelector(".editForm__name").classList.remove("is-invalid"); + editName.classList.remove("is-invalid"); + editForm.removeChild(err); }, 5000)); - } , errmsg: `konnte Kategorie nicht bearbeiten` }); From 003fba3a496936e6f198979cd9ff9f287e4318ba Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:23:15 +0200 Subject: [PATCH 09/26] styling auf innerHeader umgegelgt, header selbst ist flex --- src/main/resources/static/css/list.css | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/resources/static/css/list.css b/src/main/resources/static/css/list.css index 5292eb9..365dffa 100644 --- a/src/main/resources/static/css/list.css +++ b/src/main/resources/static/css/list.css @@ -32,7 +32,10 @@ shopping-category { border-radius: var(--radius) } -.category__header { +.category__header{ + display: flex; +} +.category__innerHeader { display: flex; align-items: center; gap: var(--space-2); @@ -56,8 +59,6 @@ shopping-category { color: var(--c-muted); margin-left: auto; } - - shopping-category > ul { list-style: none; display: flex; From c20841e475dc3013de28352ef4800f3f92c05892 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:23:23 +0200 Subject: [PATCH 10/26] =?UTF-8?q?reihenfolge=20ge=C3=A4ndert=20weilt=20son?= =?UTF-8?q?st=20error?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/shared/editing.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/static/js/shared/editing.js b/src/main/resources/static/js/shared/editing.js index e632a56..c1b7090 100644 --- a/src/main/resources/static/js/shared/editing.js +++ b/src/main/resources/static/js/shared/editing.js @@ -16,8 +16,8 @@ export async function editElement({ element, fields, apiCall, id, onSuccess, onF if (result.ok) { - onSuccess(formData); abortEditing(formElement, element); + onSuccess(formData); } else { onFailure(result); From f2538a39bc92ab154afe7fa181254a5bb1ba8298 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:23:53 +0200 Subject: [PATCH 11/26] error-message stying --- src/main/resources/static/css/base.css | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/resources/static/css/base.css b/src/main/resources/static/css/base.css index 1b99297..c9bf513 100644 --- a/src/main/resources/static/css/base.css +++ b/src/main/resources/static/css/base.css @@ -82,6 +82,9 @@ button:hover { background: var(--c-accent-hover); } /* ---- Bearbeitung ---- */ +.error-message{ + font-size: .75rem; + color: var(--c-danger); .editForm__saveButton, .editForm__abortButton { margin-top: var(--space-2); margin-right: var(--space-1); From 3b2de4a2e4cb4af759be19fd374b83c97cdee586 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:24:04 +0200 Subject: [PATCH 12/26] =?UTF-8?q?editForma=20ls=20ganzes=20gestyled,=20sty?= =?UTF-8?q?len=20einzelner=20kn=C3=B6pfe=20weg?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/css/base.css | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/main/resources/static/css/base.css b/src/main/resources/static/css/base.css index c9bf513..fe22da6 100644 --- a/src/main/resources/static/css/base.css +++ b/src/main/resources/static/css/base.css @@ -61,6 +61,7 @@ input.is-invalid:not([type="checkbox"]):not([type="radio"]), select.is-invalid { border-color: var(--c-danger); } + .is-invalid:focus-visible { outline-color: var(--c-danger); } @@ -85,13 +86,15 @@ button:hover { background: var(--c-accent-hover); } .error-message{ font-size: .75rem; color: var(--c-danger); -.editForm__saveButton, .editForm__abortButton { - margin-top: var(--space-2); - margin-right: var(--space-1); } -.editForm__name { - margin-right: var(--space-2); +.editForm { + display: flex; + flex-wrap: wrap; + align-items: center; + gap: var(--space-2); + align-items: center; + margin: var(--space-1); } From 4b83562e7b9edcc4fa9c6ec258d2867198a1c568 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:28:46 +0200 Subject: [PATCH 13/26] fehler wird angezeigt wenn item falsch editiert --- .../resources/static/js/pages/list/list.js | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index 56dd48b..dbc6a7a 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -98,19 +98,27 @@ function init() { { name: "itemAmount", value: itemAmount, class: "editForm__amount", attr: "item-amount" } ] , onSuccess: (f) => { sharedUI.setElementAttributes(shoppingItemElement, { "item-name": f.itemName, "item-amount": f.itemAmount }) } - , onFailure: (result) => { + , onFailure: (response) => { let errorTimer; - document.querySelector("input.editForm__name").classList.add("is-invalid"); - document.querySelector("input.editForm__amount").classList.add("is-invalid"); + + const editForm = document.querySelector(".editForm"); + const name = document.querySelector("input.editForm__name"); + const amount = document.querySelector("input.editForm__amount") + const err = createErrorSpan(response.json.msg); + + name.classList.add("is-invalid"); + amount.classList.add("is-invalid"); + + editForm.append(err); clearTimeout(errorTimer); errorTimer = (setTimeout(() => { - document.querySelector(".editForm__name").classList.remove("is-invalid"); - document.querySelector("input.editForm__amount").classList.remove("is-invalid"); + name.classList.remove("is-invalid"); + amount.classList.remove("is-invalid") + editForm.removeChild(err); }, 5000)); - } , errmsg: `konnte Item nicht bearbeiten` }); From 921d7aef729d74fe61a418306375bc803e7d2a61 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:34:43 +0200 Subject: [PATCH 14/26] =?UTF-8?q?showError=20implementiert=20f=C3=BCr=20mo?= =?UTF-8?q?dularit=C3=A4t?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/shared/error.js | 24 ++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/main/resources/static/js/shared/error.js b/src/main/resources/static/js/shared/error.js index b3c2f5c..f2ce5ad 100644 --- a/src/main/resources/static/js/shared/error.js +++ b/src/main/resources/static/js/shared/error.js @@ -4,3 +4,27 @@ export function createErrorSpan(msg) { span.classList.add("error-message"); return span; } + + +export function showError({ highlightFields, elementForMessage, message }) { + + highlightFields.forEach(field => { + field.classList.add("is-invalid"); + }); + + const errSpan = createErrorSpan(message); + + elementForMessage.append(errSpan); + + let errorTimer; + clearTimeout(errorTimer); + errorTimer = (setTimeout(() => { + + highlightFields.forEach(field => { + field.classList.remove("is-invalid"); + }) + + elementForMessage.removeChild(err); + }, 5000)); + +} From 3962a58bc9fd3bde63f15deddbf374bb118d3ab6 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:34:54 +0200 Subject: [PATCH 15/26] edit Funktionen nutzen jtz showError --- .../resources/static/js/pages/list/list.js | 32 +++---------------- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index dbc6a7a..28fc0f6 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -5,7 +5,7 @@ import * as ui from "./frontend/listUI.js" import { handleResponse } from "../../shared/helper.js"; import { editElement } from "../../shared/editing.js"; import * as sharedUI from "../../shared/sharedUI.js"; -import { createErrorSpan } from "../../shared/error.js"; +import { createErrorSpan, showError } from "../../shared/error.js"; const addCategoryForm = document.querySelector(".addCategoryForm"); const addItemForm = document.querySelector(".addItemForm"); @@ -99,26 +99,12 @@ function init() { ] , onSuccess: (f) => { sharedUI.setElementAttributes(shoppingItemElement, { "item-name": f.itemName, "item-amount": f.itemAmount }) } , onFailure: (response) => { - let errorTimer; const editForm = document.querySelector(".editForm"); const name = document.querySelector("input.editForm__name"); const amount = document.querySelector("input.editForm__amount") - const err = createErrorSpan(response.json.msg); - name.classList.add("is-invalid"); - amount.classList.add("is-invalid"); - - editForm.append(err); - - clearTimeout(errorTimer); - errorTimer = (setTimeout(() => { - - name.classList.remove("is-invalid"); - amount.classList.remove("is-invalid") - - editForm.removeChild(err); - }, 5000)); + showError({ highlightFields: [name, amount], elementForMessage: editForm, message: response.json.msg }); } , errmsg: `konnte Item nicht bearbeiten` }); @@ -141,20 +127,12 @@ function init() { document.querySelector(`option[value='${id}']`).textContent = f.categoryName; } , onFailure: (response) => { - let errorTimer; + const editForm = document.querySelector(".editForm"); - const editName = document.querySelector(".editForm__name"); - const err = createErrorSpan(response.json.msg); + const name = document.querySelector(".editForm__name"); - editName.classList.add("is-invalid"); - editForm.append(err); + showError({ highlightFields: [name], elementForMessage: editForm, message: response.json.msg }); - clearTimeout(errorTimer); - errorTimer = (setTimeout(() => { - - editName.classList.remove("is-invalid"); - editForm.removeChild(err); - }, 5000)); } , errmsg: `konnte Kategorie nicht bearbeiten` }); From 719c63862e5344617df29acad82e716f8643f490 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:43:20 +0200 Subject: [PATCH 16/26] =?UTF-8?q?Fehler=20wird=20angezegit=20beim=20hinzuf?= =?UTF-8?q?=C3=BCgen=20von=20Gegenstand=20und=20Kategorie?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../resources/static/js/pages/list/list.js | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index 28fc0f6..b587e67 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -15,15 +15,28 @@ const deleteAllDoneItemsButton = document.querySelector(".deleteAllDoneItemsButt async function addItem(itemName, itemAmount, categoryID) { console.log(` adding item with id:${currentList.dataset.id}, name: ${itemName}, amount: ${itemAmount}, category: ${categoryID}`) - const json = await handleResponse(api.addItem(currentList.dataset.id, itemName, itemAmount, categoryID), `item couldnt be created!`); - if (json.ok) ui.addItem(json.json); + const response = await handleResponse(api.addItem(currentList.dataset.id, itemName, itemAmount, categoryID), `item couldnt be created!`); + if (response.ok) { + ui.addItem(response.json); + } else { + const form = document.querySelector(".addItemForm"); + const name = document.querySelector(".addItemForm__nameInput"); + const amount = document.querySelector(".addItemForm__amountInput"); + showError({ highlightFields: [name, amount], elementForMessage: form, message: response.json.msg }); + } } async function addCategory(categoryName) { console.log(`adding category ${categoryName}`) - const json = await handleResponse(api.addCategory(currentList.dataset.id, categoryName), `category couldnt be added!`); - if (json.ok) ui.addCategory(json.json); + const response = await handleResponse(api.addCategory(currentList.dataset.id, categoryName), `category couldnt be added!`); + if (response.ok) { + ui.addCategory(response.json); + } else { + const form = document.querySelector(".addCategoryForm"); + const name = document.querySelector(".addCategoryForm__nameInput"); + showError({ highlightFields: [name], elementForMessage: form, message: response.json.msg }); + } } From d79be68bed9a7311ccb55aca052e091018b7b778 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:43:32 +0200 Subject: [PATCH 17/26] =?UTF-8?q?json=20zu=20response=20ge=C3=A4ndert=20un?= =?UTF-8?q?d=20success-checking=20angepasst?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/resources/static/js/pages/list/list.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/resources/static/js/pages/list/list.js b/src/main/resources/static/js/pages/list/list.js index b587e67..2e03750 100644 --- a/src/main/resources/static/js/pages/list/list.js +++ b/src/main/resources/static/js/pages/list/list.js @@ -43,21 +43,21 @@ async function addCategory(categoryName) { async function deleteItem(li) { console.log(`deleting item ${li.dataset.id}`) - const json = await handleResponse(api.deleteItem(li.dataset.id), `error deleting item`); - if (json.ok) ui.deleteItem(li); + const response = await handleResponse(api.deleteItem(li.dataset.id), `error deleting item`); + if (response.ok) ui.deleteItem(li); } async function deleteCategory(deleteAllItems, categoryID) { console.log(`deleting category with allItems: ${deleteAllItems} id: ${categoryID}`); - const json = await handleResponse(api.deleteCategory(deleteAllItems, categoryID), `error deleting category`); + const response = await handleResponse(api.deleteCategory(deleteAllItems, categoryID), `error deleting category`); - if (json.ok) ui.deleteCategory(deleteAllItems, categoryID); + if (response.ok) ui.deleteCategory(deleteAllItems, categoryID); } async function deleteAllDoneItems() { console.log(`deleting all done items...`) - const json = await handleResponse(api.deleteAllDoneItems(currentList.dataset.id), `error deleting all done items`); - if (json.ok) ui.deleteAllDoneItems(); + const response = await handleResponse(api.deleteAllDoneItems(currentList.dataset.id), `error deleting all done items`); + if (response.ok) ui.deleteAllDoneItems(); } function init() { From 5a1bac447e5bf0e4d751b3c9a040ccc8d7c39f20 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:43:38 +0200 Subject: [PATCH 18/26] err zu errSpan --- src/main/resources/static/js/shared/error.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/static/js/shared/error.js b/src/main/resources/static/js/shared/error.js index f2ce5ad..36f4d94 100644 --- a/src/main/resources/static/js/shared/error.js +++ b/src/main/resources/static/js/shared/error.js @@ -24,7 +24,7 @@ export function showError({ highlightFields, elementForMessage, message }) { field.classList.remove("is-invalid"); }) - elementForMessage.removeChild(err); + elementForMessage.removeChild(errSpan); }, 5000)); } From 0109a65d0b84130b11c365d4b8fea6cbbb23211b Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:43:43 +0200 Subject: [PATCH 19/26] =?UTF-8?q?Fehlermeldung=20hizugef=C3=BCgt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../einkaufsliste/Dto/Post/ShoppingCategoryPostDTO.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/de/timaldinger/einkaufsliste/Dto/Post/ShoppingCategoryPostDTO.java b/src/main/java/de/timaldinger/einkaufsliste/Dto/Post/ShoppingCategoryPostDTO.java index 6dc0f27..4ceac7d 100644 --- a/src/main/java/de/timaldinger/einkaufsliste/Dto/Post/ShoppingCategoryPostDTO.java +++ b/src/main/java/de/timaldinger/einkaufsliste/Dto/Post/ShoppingCategoryPostDTO.java @@ -4,5 +4,5 @@ import jakarta.validation.constraints.NotBlank; import java.util.UUID; -public record ShoppingCategoryPostDTO(@NotBlank String categoryName, UUID listID) { +public record ShoppingCategoryPostDTO(@NotBlank(message = "categoryName must not be blank!") String categoryName, UUID listID) { } From a5f0fa9ba39a7a757c45dbca9be0975425e93f6a Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:48:23 +0200 Subject: [PATCH 20/26] input listenname hat jtz eine klasse --- src/main/resources/templates/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/templates/index.html b/src/main/resources/templates/index.html index 49791d1..3d58e19 100644 --- a/src/main/resources/templates/index.html +++ b/src/main/resources/templates/index.html @@ -27,7 +27,7 @@ xmlns:th="http://www.thymeleaf.org">
- +
From 433445290cbad29c52959f480c04cf27e73be64e Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:48:33 +0200 Subject: [PATCH 21/26] indexseite zeigt fehlermeldungen an --- .../resources/static/js/pages/index/index.js | 25 ++++++++++++++----- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/main/resources/static/js/pages/index/index.js b/src/main/resources/static/js/pages/index/index.js index 56fbad1..068c768 100644 --- a/src/main/resources/static/js/pages/index/index.js +++ b/src/main/resources/static/js/pages/index/index.js @@ -1,6 +1,6 @@ import { ShoppingList } from "../../models/ShoppingList.js"; import { editElement } from "../../shared/editing.js"; -import { initErrors } from "../../shared/error.js"; +import { showError } from "../../shared/error.js"; import { handleResponse } from "../../shared/helper.js"; import { setElementAttributes } from "../../shared/sharedUI.js"; import * as api from "./api/indexAPI.js"; @@ -9,18 +9,23 @@ import * as ui from "./frontend/indexUI.js" const addListForm = document.querySelector(".addListForm"); async function addList(listName) { - const json = await handleResponse(api.addList(listName), `error creating list`); - if (json) ui.addList(json); + const response = await handleResponse(api.addList(listName), `error creating list`); + if (response.ok) { + ui.addList(response.json); + } else { + const name = document.querySelector(".addListForm__inputName"); + showError({ highlightFields: [name], elementForMessage: addListForm, message: response.msg }); + } } + async function deleteList(listElement) { - const json = await handleResponse(api.deleteList(listElement.dataset.id), `error deleting list`); - if (json) ui.deleteList(listElement); + const response = await handleResponse(api.deleteList(listElement.dataset.id), `error deleting list`); + if (response.ok) ui.deleteList(listElement); } function init() { - initErrors(document.querySelector(".nav")); customElements.define("shopping-list", ShoppingList); addListForm.addEventListener("submit", (e) => { @@ -44,6 +49,14 @@ function init() { setElementAttributes(shoppingListElement, { "list-name": f.listName }); //nav wird hier ^ aktualisiert } + , onFailure: (response) => { + + const editForm = document.querySelector(".editForm"); + const name = document.querySelector("input.editForm__name"); + + showError({ highlightFields: [name], elementForMessage: editForm, message: response.json.msg }); + } + , errmsg: `liste konnte nicht aktualsiiert werden` }) From a63ecc4de5c6ae611645d6cdf74c7a47df7d37a2 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 15:55:43 +0200 Subject: [PATCH 22/26] clientseitige falsche eingabe wird rot hervorgeoben --- src/main/resources/static/css/base.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/resources/static/css/base.css b/src/main/resources/static/css/base.css index fe22da6..01b6850 100644 --- a/src/main/resources/static/css/base.css +++ b/src/main/resources/static/css/base.css @@ -58,6 +58,7 @@ input:not([type="checkbox"]):not([type="radio"]), select { input::placeholder { color: var(--c-muted); } input.is-invalid:not([type="checkbox"]):not([type="radio"]), +input:user-invalid:not([type="checkbox"]):not([type="radio"]), select.is-invalid { border-color: var(--c-danger); } @@ -65,6 +66,7 @@ select.is-invalid { .is-invalid:focus-visible { outline-color: var(--c-danger); } + button { font: inherit; padding: var(--space-2) var(--space-3); From ce55b3b2c813ffbb4e435b7ec852c788fea076e1 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 16:08:28 +0200 Subject: [PATCH 23/26] Zeilenumbruch volle Breite --- src/main/resources/static/css/base.css | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/resources/static/css/base.css b/src/main/resources/static/css/base.css index 01b6850..3f69c0e 100644 --- a/src/main/resources/static/css/base.css +++ b/src/main/resources/static/css/base.css @@ -86,6 +86,7 @@ button:hover { background: var(--c-accent-hover); } /* ---- Bearbeitung ---- */ .error-message{ + flex-basis: 100%; font-size: .75rem; color: var(--c-danger); } From 083dfa6e7b13d500b0bd1f0849699b32ec3ff770 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 16:09:00 +0200 Subject: [PATCH 24/26] addListForm flex-wrap --- src/main/resources/static/css/index.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/resources/static/css/index.css b/src/main/resources/static/css/index.css index 94ed70d..ca9c311 100644 --- a/src/main/resources/static/css/index.css +++ b/src/main/resources/static/css/index.css @@ -2,6 +2,7 @@ display: flex; gap: var(--space-2); margin-bottom: var(--space-4); + flex-wrap: wrap; } .addListForm input { flex: 1; } @@ -19,8 +20,6 @@ border-radius: var(--radius); } - - shopping-list { display: flex; align-items: center; From f38b8b547f51693e8df1b07210b07224db9bef49 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 16:09:16 +0200 Subject: [PATCH 25/26] falsche property --- src/main/resources/static/js/pages/index/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/static/js/pages/index/index.js b/src/main/resources/static/js/pages/index/index.js index 068c768..ba85aa1 100644 --- a/src/main/resources/static/js/pages/index/index.js +++ b/src/main/resources/static/js/pages/index/index.js @@ -14,7 +14,7 @@ async function addList(listName) { ui.addList(response.json); } else { const name = document.querySelector(".addListForm__inputName"); - showError({ highlightFields: [name], elementForMessage: addListForm, message: response.msg }); + showError({ highlightFields: [name], elementForMessage: addListForm, message: response.json.msg }); } } From 3d01278a62394e3ee17fcf2148248d45350be5e2 Mon Sep 17 00:00:00 2001 From: Tim Aldinger Date: Sat, 17 Oct 2026 16:09:20 +0200 Subject: [PATCH 26/26] requried entfernt --- src/main/resources/templates/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/templates/index.html b/src/main/resources/templates/index.html index 3d58e19..47b99cf 100644 --- a/src/main/resources/templates/index.html +++ b/src/main/resources/templates/index.html @@ -27,7 +27,7 @@ xmlns:th="http://www.thymeleaf.org">
- +